Re: BUG #15844: MIPS: remove .set mips2 in s_lock.h to fix r6 build

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: YunQiang Su <wzssyqa(at)gmail(dot)com>
Cc: pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15844: MIPS: remove .set mips2 in s_lock.h to fix r6 build
Date: 2019-06-17 15:29:49
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs

I wrote:
> Sure, the trick would be to not override a (default or specified)
> architecture setting that's higher than mips2. I was imagining
> using AC_EGREP_CPP() to see if __mips expands to exactly 1. But
> on reflection, probably a better idea is to just see if asm with
> ll/sc/sync compiles, and add -march=mips2 if not.

Concretely, here's a patch that does it like that. I've verified
that this builds on my netbsd/gxemul installation.

regards, tom lane

Attachment Content-Type Size
avoid-asm-set-mips2.patch text/x-diff 4.6 KB

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2019-06-17 15:43:05 BUG #15856: The program "postgres" was found by "initdb" but was not the same version as initdb.
Previous Message Vianello, Daniel A 2019-06-17 14:47:49 RE: Not able to insert data into table