Re: libpq compression

From: Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>
To: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Robbie Harwood <rharwood(at)redhat(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Grigory Smolkin <g(dot)smolkin(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: libpq compression
Date: 2019-03-25 12:12:27
Message-ID: 396ef57f-1ede-1e88-0f08-73cedb0478dc@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 25.03.2019 13:48, Dmitry Dolgov wrote:
>> On Mon, Mar 25, 2019 at 11:39 AM David Steele <david(at)pgmasters(dot)net> wrote:
>>
>> On 3/25/19 1:04 PM, Konstantin Knizhnik wrote:
>>>
>>> On 25.03.2019 11:06, David Steele wrote:
>>>> Konstantin,
>>>>
>>>>
>>>> This patch appears to be failing tests so I have marked it Waiting on
>>>> Author.
>>>>
>>>> I have also removed the reviewer since no review had been done. Maybe
>>>> somebody else will have a look.
>>>>
>>>> Regards,
>>> Can you please inform me which tests are failed?
>>> I have done "make check-world" and there were no failed tests.
>>> Actually if compression is not enabled (and it is disabled by default
>>> unless explicitly requested by client), there should be no difference
>>> with vanilla Postgres.
>>> So it will be strange if some tests are failed without using compression.
>> Check out the cfbot report at http://commitfest.cputube.org
> I guess it's red because the last posted patch happened to be my experimental
> patch (based indeed on a broken revision v11), not the one posted by Konstantin.
Rebased version of my patch is attached.

--

Konstantin Knizhnik
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment Content-Type Size
libpq-compression-13.patch text/x-patch 43.4 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2019-03-25 12:32:04 Re: [HACKERS] WAL logging problem in 9.4.3?
Previous Message legrand legrand 2019-03-25 11:49:42 RE: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?