Re: Decoupling our alignment assumptions about int64 and double

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Aditya Kamath <Aditya(dot)Kamath1(at)ibm(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Srirama Kucherlapati <sriram(dot)rk(at)in(dot)ibm(dot)com>, AIX PG user <postgres-ibm-aix(at)wwpdl(dot)vnet(dot)ibm(dot)com>
Subject: Re: Decoupling our alignment assumptions about int64 and double
Date: 2026-02-10 20:52:18
Message-ID: 3965269.1770756738@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Aditya Kamath <Aditya(dot)Kamath1(at)ibm(dot)com> writes:
> We built the master branch with this POC patch plus meson and GNU build development patches for AIX.
> We tested this in our AIX environment using DOUBLE PRECISION and BIGINT columns to verify that pg_upgrade succeeds. We first created a PostgreSQL 15 database cluster, populated it with sample records, and then upgraded it to a master-branch build that includes this patch. The upgrade completed successfully.

Cool, thanks for testing.

Here's a fleshed-out version of that patch. I propagated the
BEGIN/END_CATALOG_STRUCT macros into all the catalog headers
and removed the for-test-purposes-only column rearrangement in
pg_subscription.h. I also elected to use the push/pop variants of the
pack pragma. This makes no difference today, since we're not using
that pragma elsewhere, but conceivably it'll make this easier to work
with in future. It's otherwise the same except for a bit more
comment-smithing.

regards, tom lane

Attachment Content-Type Size
v5-0001-Cope-with-AIX-s-alignment-woes-by-using-_Pragma-p.patch text/x-diff 61.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2026-02-10 20:53:58 Re: PGPROC alignment (was Re: pgsql: Separate RecoveryConflictReasons from procsignals)
Previous Message Andres Freund 2026-02-10 20:43:19 Re: llvmjit - improve code generated in O0