| From: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>, Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Amul Sul <sulamul(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: new heapcheck contrib module |
| Date: | 2020-10-06 23:20:22 |
| Message-ID: | 3894CAFE-E391-4EE0-9599-37C5D90BE740@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Oct 5, 2020, at 5:24 PM, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> wrote:
>
> - This version does not change clog handling, which leaves Andrey's concern unaddressed. Peter also showed some support for (or perhaps just a lack of opposition to) doing more of what Andrey suggests. I may come back to this issue, depending on time available and further feedback.
Attached is a patch set that includes the clog handling as discussed. The 0001 and 0002 are effectively unchanged since version 16 posted yesterday, but this now includes 0003 which creates a non-throwing interface to clog, and 0004 which uses the non-throwing interface from within amcheck's heap checking functions.
I think this is a pretty good sketch for discussion, though I am unsatisfied with the lack of regression test coverage of verify_heapam in the presence of clog truncation. I was hoping to have that as part of v17, but since it is taking a bit longer than I anticipated, I'll have to come back with that in a later patch.
| Attachment | Content-Type | Size |
|---|---|---|
| v17-0001-Adding-function-verify_heapam-to-amcheck-module.patch | application/octet-stream | 88.2 KB |
| v17-0002-Adding-contrib-module-pg_amcheck.patch | application/octet-stream | 84.9 KB |
| v17-0003-Creating-non-throwing-interface-to-clog-and-slru.patch | application/octet-stream | 21.8 KB |
| v17-0004-Using-non-throwing-clog-interface-from-amcheck.patch | application/octet-stream | 7.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ian Lawrence Barwick | 2020-10-07 00:48:39 | Re: [doc] clarify behaviour of pg_dump's -t/--table option with non-tables |
| Previous Message | Peter Smith | 2020-10-06 22:35:38 | Re: [HACKERS] logical decoding of two-phase transactions |