|From:||Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>|
|To:||"Jamison, Kirk" <k(dot)jamison(at)jp(dot)fujitsu(dot)com>|
|Cc:||Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, 'Alvaro Herrera' <alvherre(at)2ndquadrant(dot)com>, 'Michael Paquier' <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>|
|Subject:||Re: pg_upgrade: Pass -j down to vacuumdb|
|Views:||Raw Message | Whole Thread | Download mbox|
On 1/27/19 7:50 PM, Jamison, Kirk wrote:
> There were also helpful comments from the developers above,
> pointing it to the right direction.
> In addition to Peter's comment, quoting "...if you want to do this
> as fast as possible, don't use this script. That comment could be
> enhanced to suggest the use of the -j option.", so I think you
> should also update the following script in create_script_for_cluster_analyze():
> fprintf(script, "echo %sIf you would like default statistics as quickly as possible, cancel%s\n",
> ECHO_QUOTE, ECHO_QUOTE);
Yes, it will echo the -j option if passed, and the server supports it.
>> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
>>> So let's have it write with a $VACUUMDB_OPTS variable, which is by
>>> default defined as empty but with a comment suggesting that maybe the
>>> user wants to add the -j option. This way, if they have to edit it,
>>> they only have to edit the VACUUMDB_OPTS line instead of each of the
>>> two vacuumdb lines.
> Tom Lane wrote:
>> Even better, allow the script to absorb a value from the environment, so that it needn't be edited at all.
Attached is v3.
|Next Message||Tom Lane||2019-01-28 15:18:48||Rename nodes/relation.h => nodes/pathnodes.h ?|
|Previous Message||Daniel Verite||2019-01-28 15:06:17||Re: backslash-dot quoting in COPY CSV|