| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Bug in query rewriter - hasModifyingCTE not getting set |
| Date: | 2021-02-07 00:05:11 |
| Message-ID: | 387236.1612656311@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
After poking around a bit more, I notice that the hasRecursive flag
really ought to get propagated as well, since that's also an attribute
of the CTE list. That omission doesn't seem to have any ill effect
today, since nothing in planning or execution looks at that flag, but
someday it might. So what I think we should do is as attached.
(I re-integrated your example into with.sql, too.)
Given the very limited time remaining before the release wrap, I'm
going to go ahead and push this.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| propagate-CTE-property-flags-in-rewriter-2.patch | text/x-diff | 2.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-02-07 00:39:36 | Re: Preserve attstattarget on REINDEX CONCURRENTLY |
| Previous Message | Tom Lane | 2021-02-06 23:03:21 | Re: Bug in query rewriter - hasModifyingCTE not getting set |