Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Function structure in formatting.c

From: "Brendan Jurd" <direvus(at)gmail(dot)com>
To: pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Function structure in formatting.c
Date: 2007-10-02 08:35:21
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackerspgsql-patches
I noticed an editing error in the patch I originally submitted; it
defined the same debugging macro twice.

I've attached a fresh copy of the patch against the current HEAD with
the fix included.


On 8/11/07, Brendan Jurd <direvus(at)gmail(dot)com> wrote:
> Hello,
> As discussed on -hackers, I've done some refactoring work on
> backend/utils/adt/formatting.c, in an attempt to make the code a bit
> more intelligible before improving handling of bogus formats.
> This is purely a refactor.  The functionality of the file hasn't
> changed; it does the same job as before, but it does it in ~200 fewer
> lines and ~3.5k fewer characters.  The clarity of code is greatly
> improved.  Sadly, performance appears to be unchanged.
> Summary of changes:
>  * Did away with dch_global, dch_date and dch_time.
>  * Replaced DCH_processor with two new functions DCH_to_char and
> DCH_from_char, which now do all the work previously done by
> dch_{global,date,time}.
>  * Removed the 'action' field from the KeyWord struct as it is no longer useful.
>  * Changed the type of the 'character' field in the FormatNode struct
> to char, because ... that's what it is.  The original choice of 'int'
> seems to have been an error.
>  * Removed commented-out function declaration for is_acdc.  According
> to CVS annotate, this hasn't been in use since sometime in the early
> Cretaceous period, and in any case I don't know why you'd want to
> check whether a string was the rock band AC/DC. =)
>  * Reworded some of the comments for clarity.
>  * Didn't touch any of the number formatting routines.
> This compiles cleanly on x86 gentoo and passes check, installcheck and
> installcheck-parallel.
> Thanks for your time,
> BJ

Attachment: formatting-refactor_1.diff.gz
Description: application/x-gzip (10.0 KB)

In response to


pgsql-hackers by date

Next:From: Magnus HaganderDate: 2007-10-02 09:18:23
Subject: Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL
Previous:From: Magnus HaganderDate: 2007-10-02 06:42:28
Subject: Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL

pgsql-patches by date

Next:From: Magnus HaganderDate: 2007-10-02 08:49:38
Subject: Re: Loose check was corrected of win32.mak.
Previous:From: ITAGAKI TakahiroDate: 2007-10-02 05:38:09
Subject: ecpg thread-safe descriptor

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group