Confusing docs about GetForeignUpperPaths in fdwhandler.sgml

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Confusing docs about GetForeignUpperPaths in fdwhandler.sgml
Date: 2016-08-01 12:14:58
Message-ID: 374eb243-eb04-b45f-34bc-698b30e5f47c@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Hi,

I noticed that the following note about direct modification via
GetForeignUpperPaths in fdwhandler.sgml is a bit confusing. We have
another approach using PlanDirectModify, so that should be reflected in
the note as well. Please find attached a patch.

<function>PlanForeignModify</> and the other callbacks described in
<xref linkend="fdw-callbacks-update"> are designed around the
assumption
that the foreign relation will be scanned in the usual way and then
individual row updates will be driven by a local
<literal>ModifyTable</>
plan node. This approach is necessary for the general case where an
update requires reading local tables as well as foreign tables.
However, if the operation could be executed entirely by the foreign
server, the FDW could generate a path representing that and insert it
into the <literal>UPPERREL_FINAL</> upper relation, where it would
compete against the <literal>ModifyTable</> approach.

Best regards,
Etsuro Fujita

Attachment Content-Type Size
fdw-query-planning.patch binary/octet-stream 2.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hannu Krosing 2016-08-01 12:31:09 Re: Why we lost Uber as a user
Previous Message Vladimir Sitnikov 2016-08-01 12:12:08 Re: Slowness of extended protocol