Re: [HACKERS] Including Snapshot Info with Indexes

From: "Jonah H(dot) Harris" <jonah(dot)harris(at)gmail(dot)com>
To: "Gokulakannan Somasundaram" <gokul007(at)gmail(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Including Snapshot Info with Indexes
Date: 2008-01-23 17:19:38
Message-ID: 36e682920801230919u64ef55e4i68814fd09f38c20f@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Jan 23, 2008 11:28 AM, Gokulakannan Somasundaram <gokul007(at)gmail(dot)com> wrote:
> Fixed a type 'o'....

I'm playing with this now against 8.3 HEAD. Looks like there's a
couple things which are problematic:

- DefineIndex was updated only in bootparse.c, not in bootparse.y
- The patch contains changes to pg_config.h
- THICK isn't defined in gram.y (as a token or under
unreserved_keywords), so compilation of keywords.c fails.

In the future, please make changes to the proper pre-built files so
that someone doesn't have to configure it, then patch it. I have them
fixed and will submit the patch back here if you'd like. Or, you can
fix it. It's up to you :)

--
Jonah H. Harris, Sr. Software Architect | phone: 732.331.1324
EnterpriseDB Corporation | fax: 732.331.1301
499 Thornall Street, 2nd Floor | jonah(dot)harris(at)enterprisedb(dot)com
Edison, NJ 08837 | http://www.enterprisedb.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Guillaume Smet 2008-01-23 17:35:53 Re: Thick indexes - a look at count(1) query
Previous Message Decibel! 2008-01-23 16:49:31 Re: Strange locking choices in pg_shdepend.c

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2008-01-23 19:13:59 Re: Compile of Test example is put into win32.mak of libpq.
Previous Message Gokulakannan Somasundaram 2008-01-23 16:28:35 Re: [HACKERS] Including Snapshot Info with Indexes