Re: allow partial union-all and improve parallel subquery costing

From: Luc Vlaming <luc(at)swarm64(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: allow partial union-all and improve parallel subquery costing
Date: 2020-12-30 13:54:39
Message-ID: 36bd10c1-bae9-0520-44bb-e629d65f7321@swarm64.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 23-10-2020 07:51, Luc Vlaming wrote:
> On 14.10.20 09:38, Luc Vlaming wrote:
>> Hi,
>>
>> It seems I ran the wrong make checks to verify everything is correct
>> (make check instead
>> of make installcheck-world) and this uncovered another regress test
>> change. I also noticed
>> the statistics are sometimes giving different row count results so I
>> increased the row
>> statistics target to make sure the regress output is stable. Updated
>> patch attached which
>> now successfully runs installcheck-world for v13 and master.
>>
>> Kind regards,
>> Luc
>>
>> ________________________________________
>> From: Luc Vlaming <luc(at)swarm64(dot)com>
>> Sent: Tuesday, October 13, 2020 10:57 AM
>> To: pgsql-hackers
>> Subject: allow partial union-all and improve parallel subquery costing
>>
>> Hi,
>>
>> While developing some improvements for TPC-DS queries I found out that
>> with
>> UNION ALL partial paths are not emitted. Whilst fixing that I also
>> came across
>> the subquery costing which does not seem to consider parallelism when
>> doing
>> the costing.
>>
>> I added a simplified testcase in pg-regress to show this goes wrong, and
>> attached also a before and after explain output of tpc-ds SF100 query 5
>> based on version 12.4.
>>
>> I hope I followed all etiquette and these kind of improvements are
>> welcome.
>>
>> Kind regards,
>> Luc
>> Swarm64
>>
>
> Hi,
>
> Created a commitfest entry assuming this is the right thing to do so
> that someone can potentially pick it up during the commitfest.
>
> Kind regards,
> Luc
> Swarm64

Hi,

Providing an updated patch based on latest master.

Cheers,
Luc

Attachment Content-Type Size
v3-0001-Allow-partial-UNION-ALL-improve-parallel-subquery.patch text/x-patch 6.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message 赵锐 2020-12-30 14:15:24 Re: adding partitioned tables to publications
Previous Message Simon Riggs 2020-12-30 13:53:45 Re: Disable WAL logging to speed up data loading