Re: bug in SignalSomeChildren

From: Bernd Helmle <mailings(at)oopsware(dot)de>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: bug in SignalSomeChildren
Date: 2011-01-20 12:53:19
Message-ID: 36D5FC9E5C6D08B0EADD48B0@amenophis
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

--On 22. Dezember 2010 15:51:09 +0900 Fujii Masao <masao(dot)fujii(at)gmail(dot)com>

>>> How about doing target != ALL test at the head for the most common case
>>> (target == ALL)?
>> That's an idea, but the test you propose implements it incorrectly.
> Thanks! I revised the patch.

I had a look at this for the current CF and the patch looks reasonable to
me. Some testing shows that the changes are working as intended (at least,
the wal sender actually receives now signals from SignalSomeChildren() as
far as the DEBUG4 output shows). Maybe we should put in a small comment,
why we special case BACKEND_TYPE_ALL (following Tom's comment about
expensive shared memory access and IsPostmasterChildWalSender()). I marked
it as "Ready for Committer".

Question for my understanding:

While reading the small patch, i realized that there's no
BACKEND_TYPE_WALRECV or similar. If i understand correctly there's no need
to handle it this way, since there's only one wal receiver process per



In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Itagaki Takahiro 2011-01-20 13:21:37 Re: SQL/MED - file_fdw
Previous Message Magnus Hagander 2011-01-20 12:51:44 Re: pg_basebackup for streaming base backups