Re: Yet another fast GiST build

From: "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Darafei Komяpa Praliaskouski <me(at)komzpa(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Yet another fast GiST build
Date: 2020-02-29 12:13:20
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


> On 24 февр. 2020 г., at 13:50, Andrey M. Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
> Hi Thomas!
> Thanks for looking into this! I’ll fix your notices asap.

PFA v5.
Thomas, I've used your wording almost exactly with explanation how
point_zorder_internal() works. It has more explanation power than my attempts
to compose good comment.

There is one design decision that worries me most:
should we use opclass function or index option to provide this sorting information?
It is needed only during index creation, actually. And having extra i-class only for fast build
seems excessive.
I think we can provide both ways and let opclass developers decide?


Best regards, Andrey Borodin.

Attachment Content-Type Size
v5-0001-Add-sort-support-for-point-gist_point_sortsupport.patch application/octet-stream 2.5 KB
v5-0002-Implement-GiST-build-using-sort-support.patch application/octet-stream 22.1 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Erik Rijkers 2020-02-29 12:20:02 Re: Yet another fast GiST build (typo)
Previous Message Juan José Santamaría Flecha 2020-02-29 11:36:05 Re: BUG #15858: could not stat file - over 4GB