Re: pgsql: Fix our Windows stat() emulation to handle file sizes > 4GB.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix our Windows stat() emulation to handle file sizes > 4GB.
Date: 2024-11-08 16:03:00
Message-ID: 3647360.1731081780@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Thu, Nov 7, 2024 at 6:19 PM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>> Juan José Santamaría Flecha, reviewed by Emil Iggland;
>> based on prior work by Michael Paquier, Sergey Zubkovsky, and others
>>
>> Author: Alexandra Wang <alexandra(dot)wang(dot)oss(at)gmail(dot)com>

> This authorship information is confusing.

Yes. Worse, there is no link to what prompted this sudden burst
of back-patches of years-old commits. After digging around I guess
it was this thread:

https://www.postgresql.org/message-id/flat/CA%2BpA0kLc5VxOaO4WfLjmh7W0V%2BquVvVtT5CaRVRAZMuh0zft4Q%40mail.gmail.com

I'm nervous about pushing these in mere hours before a release freeze,
primarily because there's no way to be sure whether any necessary
follow-up fixes got missed. If we were unwilling to back-patch at
the time, is reversing that decision such a good idea?

I'm also confused about how to document them in the release notes.
Alexandra should get some credit I guess for collecting and testing
the patches, but she's not the original author(s).

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2024-11-08 18:10:43 pgsql: Avoid nbtree parallel scan currPos confusion.
Previous Message Robert Haas 2024-11-08 13:45:27 Re: pgsql: Fix our Windows stat() emulation to handle file sizes > 4GB.