Re: Command Triggers, patch v11

From: "anarazel(at)anarazel(dot)de" <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, Thom Brown <thom(at)linux(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>
Subject: Re: Command Triggers, patch v11
Date: 2012-02-28 00:29:20
Message-ID: 35d4fa81-9f08-49ec-a09b-5ce1b3ab1035@email.android.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> schrieb:

>Andres Freund <andres(at)anarazel(dot)de> writes:
>> I refreshed the patch so it works again on current HEAD. Basically
>some
>> trivial fixes and dfd26f9c5f371437f243249025863ea9911aacaa. The
>latter doesn't
>> seem necessary to me after the changes, so I simply ditched it. Am I
>missing
>> something?
>
>No, that was only needed because execMain.c was overriding somebody
>else's tuple receiver. If you're putting the right receiver into the
>QueryDesc to start with, it shouldn't be necessary.
>
>I'm confused by this though:
>
>> This basically includes a revert of
>d8fb1f9adbddd1eef123d66a89a9fc0ecd96f60b
>
>I don't find that commit ID anywhere.
That should have been the aforementioned commit. Must have screwed up the copy&paste buffer. Sorry for that.

Andres

Please excuse the brevity and formatting - I am writing this on my mobile phone.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2012-02-28 02:12:08 Re: Command Triggers
Previous Message Noah Misch 2012-02-28 00:28:14 Re: foreign key locks, 2nd attempt