|From:||Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>|
|To:||Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>|
|Subject:||Re: Dubious usage of TYPCATEGORY_STRING|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
> Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
>> Could we add explicit casts (like polcmd::text) here? Or would it break
>> too much?
> I assumed it'd break too much to consider doing that. But I suppose
> that since a typcategory change would be initdb-forcing anyway, maybe
> it's not out of the question. I'll investigate and see exactly how
> many places would need an explicit cast.
Um, I definitely gave up too easily there. The one usage in \dp
seems to be the *only* thing that breaks in describe.c, and pg_dump
doesn't need any changes so far as check-world reveals. So let's
just move "char" to another category, as attached.
regards, tom lane
|Next Message||Robert Haas||2021-12-07 20:27:36||Re: Why doesn't pgstat_report_analyze() focus on not-all-visible-page dead tuple counts, specifically?|
|Previous Message||Andrew Dunstan||2021-12-07 19:26:55||Re: MSVC SSL test failure|