Re: unsigned and signed chars in libpq API

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Dmitriy Igrishin <dmitigr(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: unsigned and signed chars in libpq API
Date: 2012-08-27 16:40:37
Message-ID: 3517.1346085637@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> On Thu, Feb 2, 2012 at 10:33:24AM +0300, Dmitriy Igrishin wrote:
>> Could you tell me please an objective reason why PQunescapeBytea()
>> returns unsigned char* rather than just char* ?
>> I am asking because a bit confused. How this intermixes with LO's API,
>> which based on signed chars (although as we all know large object -
>> is a just bytea splitted on chunks)?
>> And also PQgetvalue() returns char* rather than unsigned char*.

> Can someone answer this? Are we consistent here?

We're not, particularly, but changing any of this seems likely to
create more pain than it removes.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2012-08-27 16:46:18 Useless removal of duplicate GIN index entries in pg_trgm
Previous Message Robert Haas 2012-08-27 16:39:02 Re: Timing overhead and Linux clock sources