Skip site navigation (1) Skip section navigation (2)

Re: pg_dump.options.diff

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Serguei Mokhov" <mokhov(at)cs(dot)concordia(dot)ca>
Cc: "Manfred Koizar" <mkoi-pg(at)aon(dot)at>,"PostgreSQL Hackers" <pgsql-hackers(at)postgresql(dot)org>,"Peter Eisentraut" <peter_e(at)gmx(dot)net>
Subject: Re: pg_dump.options.diff
Date: 2003-01-02 20:20:35
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackerspgsql-patches
"Serguei Mokhov" <mokhov(at)cs(dot)concordia(dot)ca> writes:
> Now, this:

> #if defined(HAVE_GETOPT_LONG)
> #define xo(long,short,desc)  printf("%s %s\n", long, desc)
> #else
> #define xo(long,short,desc)  printf("%s %s\n", short, desc)
> #endif

> seems relatively generic, so it could be used by more than one tool.

But there's no good place to put it.  I'd say just stick it into each
tool; it's no worse than repeating the existence of a "usage()"
subroutine in each tool.

> Is pushing it up to c.h an option,

I'd vote against that.

>> The trouble I see there is that the layout --- in particular the column
>> width --- would be embedded in such a routine and not alterable by
>> simply replacing message texts.

> True, but what would be wrong by having an argument for the column width?

The translator would have no control over such an argument --- at least
not without some mechanism outside the .po files.

			regards, tom lane

In response to


pgsql-hackers by date

Next:From: Jeroen T. VermeulenDate: 2003-01-02 20:30:57
Subject: Re: [HACKERS] Cast your vote ...
Previous:From: Dan LangilleDate: 2003-01-02 20:07:48
Subject: Re: [HACKERS] Cast your vote ...

pgsql-patches by date

Next:From: Serguei MokhovDate: 2003-01-02 22:51:55
Subject: Re: pg_dump.options.diff
Previous:From: Serguei MokhovDate: 2003-01-02 20:04:12
Subject: Re: pg_dump.options.diff

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group