Re: improving speed of make check-world

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: improving speed of make check-world
Date: 2015-04-29 04:12:42
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Tue, Apr 28, 2015 at 1:46 AM, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
>> This change fixed the problem for me.
>> It also made this age-old compiler warning go away:
>> In file included from gram.y:14515:
>> scan.c: In function 'yy_try_NUL_trans':
>> scan.c:10307: warning: unused variable 'yyg'
>> I guess by redirecting it into the log file you indicated, but is that a
>> good idea to redirect stderr?

> I am sure that Peter did that on purpose, both approaches having
> advantages and disadvantages. Personally I don't mind looking at the
> install log file in tmp_install to see the state of the installation,
> but it is true that this change is a bit disturbing regarding the fact
> that everything was directly outputted to stderr and stdout for many
> years.

Hm. I don't really like the idea that "make all" behaves differently
if invoked by "make check" than if invoked directly. Hiding warnings
from you is not very good, and hiding errors would be even more annoying.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-04-29 04:30:58 Re: BUG #13126: table constraint loses its comment
Previous Message Tom Lane 2015-04-29 03:55:02 Re: FIX : teach expression walker about RestrictInfo