|From:||Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>|
|To:||Surafel Temesgen <surafel3000(at)gmail(dot)com>|
|Cc:||Robert Haas <robertmhaas(at)gmail(dot)com>, andrew(at)tao11(dot)riddles(dot)org(dot)uk, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: FETCH FIRST clause WITH TIES option|
|Views:||Raw Message | Whole Thread | Download mbox|
On 11/24/18 10:28 AM, Surafel Temesgen wrote:
> Attach is rebased patch against the current master
> On Thu, Nov 1, 2018 at 2:28 PM Surafel Temesgen <surafel3000(at)gmail(dot)com
> <mailto:surafel3000(at)gmail(dot)com>> wrote:
> The attached patch include all the comment given by Tomas and i
> check sql standard about LIMIT and this feature
Unfortunately, it seems the "limit" regression tests fail for some
reason - the output mismatches the expected results for some reason. It
seems as if the WITH TIES code affects ordering of the results within
the group. See the attached file.
> it did not say anything about it but I think its good idea to
> include it to LIMIT too and I will add it if we have consensus on it.
Hmm, I'm not sure that's needed. I don't see an urgent need to do that
in v1 of the patch.
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
|Next Message||Tomas Vondra||2019-01-01 17:39:12||Re: shared-memory based stats collector|
|Previous Message||Nikolay Shaplov||2019-01-01 16:44:04||Re: [PATCH] check for ctags utility in make_ctags|