Re: [EXTERNAL] Re: Add ETIMEDOUT to ALL_CONNECTION_FAILURE_ERRNOS

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jelte Fennema <Jelte(dot)Fennema(at)microsoft(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [EXTERNAL] Re: Add ETIMEDOUT to ALL_CONNECTION_FAILURE_ERRNOS
Date: 2021-10-01 11:50:37
Message-ID: 3299683.1633089037@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jelte Fennema <Jelte(dot)Fennema(at)microsoft(dot)com> writes:
> Personally, I would love to see this backpatched. Since together with a second bug I reported[1] it's causing high query timeouts in Citus even if tcp_user_timeout is set to a low value. I do understand your worry though. Would a patch like the one I attached now be a better fit for a backport?

The only way that could work as-intended is if c.h includes whatever
header provides TCP_USER_TIMEOUT, which does not seem like a great idea.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2021-10-01 12:05:05 Re: Memory leak in pg_hmac_final
Previous Message Daniel Gustafsson 2021-10-01 11:22:04 Re: Warn if initdb's --sync-only option is mixed with other options