Re: OpenSSL Applink

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Dave Page" <dpage(at)postgresql(dot)org>
Cc: "Magnus Hagander" <magnus(at)hagander(dot)net>, "Andrew Dunstan" <andrew(at)dunslane(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: OpenSSL Applink
Date: 2007-09-29 14:45:06
Message-ID: 3260.1191077106@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

"Dave Page" <dpage(at)postgresql(dot)org> writes:
>> From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
>> ... It's not entirely clear whether BIO_new_fp() would avoid the
>> problematic calls, but it doesn't look like it'd be hard to try.

> The last version of the patch I posted uses BIO_new_file() in all cases, and (from memory) BIO_get_fp() in the non-win32 case to get a FILE* to pass to fstat.

Did you manage to get rid of the bogus-error-message problem that
afflicted the first version of the patch? If so, this way is fine.
If not, keeping control of file-opening in our own hands might be
a way to dodge that.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-09-29 14:50:34 Re: [COMMITTERS] pgsql: Temporarily modify tsearch regression tests to suppress notice
Previous Message Bruce Momjian 2007-09-29 11:14:25 Re: [COMMITTERS] pgsql: Temporarily modify tsearch regression tests to suppress notice