SSL test names

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: SSL test names
Date: 2018-02-07 16:54:52
Message-ID: 31dc0902-9780-5ee3-07ed-f5176ed2b0e6@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Here is a patch that gives the tests in the SSL test suite proper names
instead of just writing out the connection strings. So instead of

# running client tests
# test that the server doesn't accept non-SSL connections
ok 1 - sslmode=disable (should fail)
# connect without server root cert
ok 2 - sslrootcert=invalid sslmode=require
ok 3 - sslrootcert=invalid sslmode=verify-ca (should fail)
ok 4 - sslrootcert=invalid sslmode=verify-full (should fail)

you get something like

# running client tests
ok 1 - server doesn't accept non-SSL connections
ok 2 - connect without server root cert sslmode=require
ok 3 - connect without server root cert sslmode=verify-ca
ok 4 - connect without server root cert sslmode=verify-full
ok 5 - connect with wrong server root cert sslmode=require
ok 6 - connect with wrong server root cert sslmode=verify-ca
ok 7 - connect with wrong server root cert sslmode=verify-full

I have found the old way very confusing while working with several
SSL-related patches recently.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
0001-Refine-SSL-tests-test-name-reporting.patch text/plain 14.8 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2018-02-07 17:02:38 Re: [HACKERS] [PATCH] Vacuum: Update FSM more frequently
Previous Message Arthur Zakirov 2018-02-07 16:28:29 Re: [PROPOSAL] Shared Ispell dictionaries