Re: old_snapshot: add test for coverage

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Dong Wook Lee <sh95119(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: old_snapshot: add test for coverage
Date: 2022-08-08 05:37:28
Message-ID: 319829.1659937048@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dong Wook Lee <sh95119(at)gmail(dot)com> writes:
> I wrote a test of the old_snapshot extension for coverage.

Hmm, does this really provide any meaningful coverage? The test
sure looks like it's not doing much.

I spent some time a week or so ago trying to graft testing of
contrib/old_snapshot into src/test/modules/snapshot_too_old.
I didn't come up with anything I liked, but I still think
that that might lead to a more thorough test than a standalone
exercise.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2022-08-08 06:11:24 Re: Perform streaming logical transactions by background workers and parallel apply
Previous Message vignesh C 2022-08-08 04:51:24 Re: Handle infinite recursion in logical replication setup