Re: Initial review of xslt with no limits patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Mike Fowler <mike(at)mlfowler(dot)com>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Initial review of xslt with no limits patch
Date: 2010-08-06 16:15:00
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Mike Fowler <mike(at)mlfowler(dot)com> writes:
> xslt_process( ... , ... ,
> 'n1=v1,n2=v2,n3=v3,n4=v4,n5=v5'::text)


> <samples>
> <sample>v1</sample>
> <sample>v2</sample>
> <sample>v3</sample>
> <sample>v4</sample>
> <sample>v5</sample>
> </samples>

> Sadly I get the following in both versions:

> <samples>
> <sample/>
> <sample/>
> <sample/>
> <sample/>
> <sample/>
> </samples>

Some examination of
suggests that the parameter values need to be single-quoted,
and indeed when I change the last part of your example to


I get

<samples> +
</samples> +

(1 row)

So this seems to be a documentation problem more than a code problem.

(It's a bit distressing to notice that the regression tests for the
module fail to exercise 3-parameter xslt_process at all, though.)

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2010-08-06 16:26:37 Re: refactoring comment.c
Previous Message Robert Haas 2010-08-06 16:08:59 Re: refactoring comment.c