Re: Partial aggregates pushdown

From: Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Ilya Gladyshev <i(dot)gladyshev(at)postgrespro(dot)ru>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Partial aggregates pushdown
Date: 2021-11-03 14:50:19
Message-ID: 317f8de58ce9889e056f2944e200a44d@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Daniel Gustafsson писал 2021-11-03 16:45:
>> On 2 Nov 2021, at 10:12, Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru>
>> wrote:
>
>> Updated and rebased patch.
>
> + state = (Int128AggState *) palloc0(sizeof(Int128AggState));
> + state->calcSumX2 = false;
> +
> + if (!PG_ARGISNULL(0))
> + {
> +#ifdef HAVE_INT128
> + do_int128_accum(state, (int128) PG_GETARG_INT64(0));
> +#else
> + do_numeric_accum(state, int64_to_numeric(PG_GETARG_INT64(0)));
> +#endif
>
> This fails on non-INT128 platforms as state cannot be cast to
> Int128AggState
> outside of HAVE_INT128; it's not defined there. This needs to be a
> PolyNumAggState no?

Hi.
Thank you for noticing this. It's indeed fails with
pgac_cv__128bit_int=no.
Updated patch.
--
Best regards,
Alexander Pyhalov,
Postgres Professional

Attachment Content-Type Size
0001-Partial-aggregates-push-down-v06.patch text/x-diff 58.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Geoff Winkless 2021-11-03 14:54:12 Re: Should we support new definition for Identity column : GENERATED BY DEFAULT ON NULL?
Previous Message Robert Haas 2021-11-03 14:48:48 Re: Parallelize correlated subqueries that execute within each worker