| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, "wangsh(dot)fnst(at)fujitsu(dot)com" <wangsh(dot)fnst(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: invalid data in file backup_label problem on windows |
| Date: | 2021-03-31 13:33:25 |
| Message-ID: | 30780930-abab-2d1c-32a0-597604765e69@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/29/21 4:34 AM, Magnus Hagander wrote:
> On Mon, Mar 29, 2021 at 7:01 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>>
>> On Sun, Mar 28, 2021 at 09:29:10AM -0400, Andrew Dunstan wrote:
>>> - vital to the backup working, and must be written without modification.
>>> + vital to the backup working and must be written without
>>> modification, which
>>> + may include opening the file in binary mode.
>>
>> += "on Windows"?
>
> I'd say no, better to just tell people to always open the file in
> binary mode. It's not hurtful anywhere, there's really no reason ever
> to open it in text mode.
Agreed. New patch attached.
Regards,
--
-David
david(at)pgmasters(dot)net
| Attachment | Content-Type | Size |
|---|---|---|
| backup-binary-mode-v3.patch | text/plain | 713 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Arseny Sher | 2021-03-31 13:39:39 | Re: Flaky vacuum truncate test in reloptions.sql |
| Previous Message | Denis Hirn | 2021-03-31 13:31:29 | Re: [PATCH] Allow multiple recursive self-references |