Re: [PATCH] Fix pg_upgrade test from v10

From: "Anton A(dot) Melnikov" <aamelnikov(at)inbox(dot)ru>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Fix pg_upgrade test from v10
Date: 2022-07-05 06:01:49
Message-ID: 2e449c08-a38a-9636-c243-e855ae6d0c07@inbox.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello!

On 01.07.2022 20:07, Justin Pryzby wrote:
> Would you add this to to the (next) CF ?

Yes, i've put it on september CF.

> It's silly to say that v9.2 will be supported potentially for a handful more
> years, but that the upgrade-testing script itself doesn't support that, so
> developers each have to reinvent its fixups.

I've test the attached patch in all variants from v9.5..15 to supported
versions 10..master. The script test.sh for 9.5->10 and 9.6->10 upgrades
works fine without any patch.
In 9.4 there is a regress test largeobject to be patched to allow
upgrade test from this version.So i've stopped at 9.5.
This is clear that we limit the destination version for upgrade test to
the supported versions only. In our case destination versions
starting from the 10th inclusively.
But is there are a limit for the source version for upgrade test from?

> See also 20220122183749(dot)GO23027(at)telsasoft(dot)com, where I proposed some of the
> same things.
>
Thanks a lot, i've add some code for 14+ from
https://www.postgresql.org/message-id/flat/20220122183749.GO23027%40telsasoft.com
to the attached patch.

With best regards,

--
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment Content-Type Size
v3-0001-For-master-Fix-upgrade-test-from-v10-and-earl.patch text/x-patch 2.4 KB
v3-0001-For-v11-Fix-upgrade-test-from-v10-and-earl.patch text/x-patch 2.4 KB
v3-0001-For-v12-Fix-upgrade-test-from-v10-and-earl.patch text/x-patch 2.3 KB
v3-0001-For-v13-Fix-upgrade-test-from-v10-and-earl.patch text/x-patch 2.3 KB
v3-0001-For-v14-Fix-upgrade-test-from-v10-and-earl.patch text/x-patch 3.2 KB
v3-0001-For-v15-Fix-upgrade-test-from-v10-and-earl.patch text/x-patch 2.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2022-07-05 06:13:21 Re: AIX support - alignment issues
Previous Message Tom Lane 2022-07-05 05:36:24 Re: AIX support - alignment issues