Re: [EXTERNAL] Re: Add non-blocking version of PQcancel

From: Denis Laxalde <denis(dot)laxalde(at)dalibo(dot)com>
To: Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, Jelte Fennema <Jelte(dot)Fennema(at)microsoft(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [EXTERNAL] Re: Add non-blocking version of PQcancel
Date: 2024-03-06 14:03:20
Message-ID: 2e2933ad-86b4-4fea-8876-5fcc0307e97c@dalibo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

In patch 0004, I noticed a couple of typos in the documentation; please
find attached a fixup patch correcting these.

Still in the documentation, same patch, the last paragraph documenting
PQcancelPoll() ends as:

+ indicate the current stage of the connection procedure and might
be useful
+ to provide feedback to the user for example. These statuses are:
+ </para>

while not actually listing the "statuses". Should we list them? Adjust
the wording? Or refer to PQconnectPoll() documentation (since the
paragraph is copied from there it seems)?

Otherwise, the feature still works fine as far as I can tell.

Attachment Content-Type Size
0001-fixup-libpq-Add-encrypted-and-non-blocking-versions-.patch text/x-patch 1.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Aleksander Alekseev 2024-03-06 14:09:47 Re: Reducing the log spam
Previous Message Bharath Rupireddy 2024-03-06 14:02:28 Re: Add new error_action COPY ON_ERROR "log"