readdir is incorrectly implemented at Windows

From: Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: readdir is incorrectly implemented at Windows
Date: 2019-02-25 15:38:16
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi hackers,

Small issue with readir implementation for Windows.
Right now it returns ENOENT in case of any error returned by FindFirstFile.
So all places in Postgres where opendir/listdir are used will assume
that directory is empty and
do nothing without reporting any error.
It is not so good if directory is actually not empty but there are not
enough permissions for accessing the directory and FindFirstFile

struct dirent *
readdir(DIR *d)
    WIN32_FIND_DATA fd;

    if (d->handle == INVALID_HANDLE_VALUE)
        d->handle = FindFirstFile(d->dirname, &fd);
        if (d->handle == INVALID_HANDLE_VALUE)
            errno = ENOENT;
            return NULL;

Attached please find small patch fixing the problem.

Konstantin Knizhnik
Postgres Professional:
The Russian Postgres Company

Attachment Content-Type Size
dirent.patch text/x-patch 485 bytes


Browse pgsql-hackers by date

  From Date Subject
Next Message Laurenz Albe 2019-02-25 15:43:40 Re: Should we increase the default vacuum_cost_limit?
Previous Message Stephen Frost 2019-02-25 15:37:56 Re: Remove Deprecated Exclusive Backup Mode