| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: error message when subscription target is a partitioned table |
| Date: | 2018-12-06 04:46:34 |
| Message-ID: | 2c7b9ab0-67e6-fd94-ba17-dbfe80ed4ba5@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018/12/06 13:19, Michael Paquier wrote:
> On Thu, Dec 06, 2018 at 11:34:19AM +0900, Amit Langote wrote:
>> Adding to January CF.
>
> Okay, that looks good to me based on your arguments upthread.
Thanks for looking.
> A
> small-ish comment I have is that you could use a set of if/else if
> conditions instead of separate ifs.
Okay, no problem. Updated patch attached.
Thanks,
Amit
| Attachment | Content-Type | Size |
|---|---|---|
| partitioned-table-not-supported-error-logrep-v3.patch | text/plain | 1011 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2018-12-06 04:50:39 | Re: Query with high planning time at version 11.1 compared versions 10.5 and 11.0 |
| Previous Message | Michael Paquier | 2018-12-06 04:46:26 | Re: Hint and detail punctuation |