Re: tab complete for explain SETTINGS

On 2019/09/27 11:20, Justin Pryzby wrote:
> Here's to hoping this is the worst omission in v12.
>
> Justin
>

Hi Justin,

I share my test result of your patch.

I used two commits REL_12_RC1 and Head, and got a Hunk below:

#REL_12_RC1 (17822c0e4f5ab8093e78f665c9e44766ae648a44)
=============================
$ patch -p1 <v1-0001-tab-completion-for-explain-SETTINGS.patch
(Stripping trailing CRs from patch; use --binary to disable.)
patching file src/bin/psql/tab-complete.c
Hunk #1 succeeded at 2886 (offset -57 lines).
=============================

#Head (fbfa5664882c9b61428266e6fb0d48b0147c421a)
=============================
$ patch -p1 <v1-0001-tab-completion-for-explain-SETTINGS.patch
(Stripping trailing CRs from patch; use --binary to disable.)
patching file src/bin/psql/tab-complete.c
Hunk #1 succeeded at 2940 (offset -3 lines).
=============================

Anyway, I tested the patch and it looks fine. :)

#Test result of tab-completion on Head
=============================
# explain (
ANALYZE BUFFERS COSTS FORMAT SETTINGS SUMMARY TIMING VERBOSE

# explain (s
settings summary

# explain (settings ON ) select * from pg_class;
QUERY PLAN
-------------------------------------------------------------
Seq Scan on pg_class (cost=0.00..16.95 rows=395 width=265)
Settings: geqo_threshold = '10'
(2 rows)
=============================

Thanks,
Tatsuro Yamada