| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Rod Taylor <rbt(at)zort(dot)ca>, pgsql-patches(at)postgresql(dot)org, Hackers List <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Fixes gram.y |
| Date: | 2002-03-19 16:54:44 |
| Message-ID: | 29701.1016556884@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Peter Eisentraut wrote:
>> There is a standard for this. CREATE DOMAIN shows CREATE DOMAIN.
> OK, CVS changed to emit CREATE DOMAIN.
What's standard about it? I count 9 existing statements that use
"CREATE", vs 4 that use "CREATE xxx". (And of those four, CREATE
VERSION is dead code...) The closest existing statement, CREATE
TYPE, emits "CREATE".
Plain "CREATE" seems like the conforming choice, unless we'd like
to do a wholesale revision of existing command tags. Which is
not necessarily an unreasonable thing to do. But just making CREATE
DOMAIN emit "CREATE DOMAIN" isn't improving consistency at all.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2002-03-19 16:56:23 | Re: [HACKERS] Fixes gram.y |
| Previous Message | Bruce Momjian | 2002-03-19 16:12:54 | Re: [HACKERS] Fixes gram.y |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2002-03-19 16:56:23 | Re: [HACKERS] Fixes gram.y |
| Previous Message | Bruce Momjian | 2002-03-19 16:17:57 | Re: Adding usernames to pg_hba.conf |