Skip site navigation (1) Skip section navigation (2)

Re: contrib/pg_stat_statements 1226

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org, "Alex Hunsaker" <badalex(at)gmail(dot)com>
Subject: Re: contrib/pg_stat_statements 1226
Date: 2009-01-04 21:57:59
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
I wrote:
> I'm not enamored of "saved_file" either, it seems like the wrong
> part of speech somehow.  Maybe "save_in_file"?

Actually ... what is the point of letting users control the filename at
all?  It seems like the only useful nondefault value is the empty string
(to suppress storing the stats).  So why not simplify this to a boolean?
"" = on or off.

			regards, tom lane

In response to

pgsql-hackers by date

Next:From: Alvaro HerreraDate: 2009-01-04 22:01:21
Subject: Re: generic reloptions improvement
Previous:From: Alvaro HerreraDate: 2009-01-04 21:36:11
Subject: Re: generic reloptions improvement

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group