Re: Yet another fast GiST build

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
Cc: Darafei Komяpa Praliaskouski <me(at)komzpa(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Yet another fast GiST build
Date: 2019-09-01 10:53:26
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> 30 авг. 2019 г., в 16:44, Andrey Borodin <x4mmm(at)yandex-team(dot)ru> написал(а):
> How do you think, should I supply GiST-build patch with docs and tests and add it to CF? Or do we need more design discussion before?

PFA v2: now sort support is part of opclass.
There's a problem with Z-ordering NaN which causes regression tests to fail. So I decided not to add patch to CF (despite having few minutes to do so).
How to correctly Z-order NaN? So that it would be consistent with semantics of union() and consistent() functions. If one of values is NaN, then we consider all it's bits to be 1?

BTW patch uses
union {
float f;
uint32 i;
I hope it's OK, because AFAIK we do not have non-IEEE-754 platforms now.


Best regards, Andrey Borodin.

Attachment Content-Type Size
v2-0001-Add-sort-support-for-point-gist_point_sortsupport.patch application/octet-stream 2.5 KB
v2-0002-Implement-GiST-build-using-sort-support.patch application/octet-stream 16.5 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2019-09-01 11:57:06 Re: refactoring - share str2*int64 functions
Previous Message Erik Rijkers 2019-09-01 09:09:11 Re: row filtering for logical replication