Re: [PATCH] Move user options to the end of the command in pg_upgrade

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Patrik Novotny <panovotn(at)redhat(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Move user options to the end of the command in pg_upgrade
Date: 2019-09-10 14:13:49
Message-ID: 28824.1568124829@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Patrik Novotny <panovotn(at)redhat(dot)com> writes:
> when the environment variable POSTGRESQL_UPGRADE_PGUPGRADE_OPTIONS is
> used to specify options for pg_upgrade, options related to
> unix_socket_directory/ies are being overridden by hardcoded options,
> making it difficult to upgrade in some usecases.

> The attached patch changes the order of those options so that the
> hardcoded ones are eventually overridden by the user specified
> options.

Hi Patrik,

It looks like you forgot to attach the patch? But in any case,
I see no references to POSTGRESQL_UPGRADE_PGUPGRADE_OPTIONS in
any community Postgres code, so I'm wondering if this is just
changing some script that Red Hat supplies as part of packaging.
That would make it not our concern, really.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Patrik Novotny 2019-09-10 14:46:58 Re: [PATCH] Move user options to the end of the command in pg_upgrade
Previous Message Tom Lane 2019-09-10 13:48:48 Re: Pulling up direct-correlated ANY_SUBLINK