| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | Andrew Francis <locust(at)familyhealth(dot)com(dot)au>, pgsql-hackers-win32(at)postgresql(dot)org, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: libpq build problem with <io.h> on MS VC++ |
| Date: | 2004-08-17 03:56:37 |
| Message-ID: | 28759.1092714997@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers-win32 pgsql-patches |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> The only other option I can think of is to #undef those to defines,
> include io.h, then re-include port.h? Is that better?
How about not #define'ing rename() etc in port.h in the first place?
We could put
#ifdef WIN32
#define rename(x) pgrename(x)
#endif
into those very few .c files that need it. (I'm assuming that
forgetting to include this in a file that calls rename() will yield an
obvious build failure on Windows --- if not then the idea is no good.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2004-08-17 04:14:39 | Re: libpq build problem with <io.h> on MS VC++ |
| Previous Message | Bruce Momjian | 2004-08-17 03:52:45 | Re: libpq build problem with <io.h> on MS VC++ |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2004-08-17 04:14:39 | Re: libpq build problem with <io.h> on MS VC++ |
| Previous Message | Bruce Momjian | 2004-08-17 03:52:45 | Re: libpq build problem with <io.h> on MS VC++ |