| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | horiguchi(dot)kyotaro(at)oss(dot)ntt(dot)co(dot)jp, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [v9.2] make_greater_string() does not return a string in some cases |
| Date: | 2011-10-29 19:35:27 |
| Message-ID: | 28652.1319916927@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> I've committed this, after a good deal of hacking on the comments,
> some coding style cleanup, and one bug fix:
Ummm ... why do the incrementer functions think they need to restore the
previous value on failure? AFAICS that's a waste of code and cycles,
since there is only one caller and it doesn't care in the least.
I'm also quite distressed that you ignored my advice to limit the number
of combinations tried. This patch could be horribly slow when dealing
with wide characters, eg think what will happen when starting from
U+10000.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-10-29 20:15:16 | Re: [v9.2] make_greater_string() does not return a string in some cases |
| Previous Message | Robert Haas | 2011-10-29 18:26:28 | Re: [v9.2] make_greater_string() does not return a string in some cases |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-10-29 20:07:02 | Re: pg_upgrade if 'postgres' database is dropped |
| Previous Message | Tom Lane | 2011-10-29 19:13:00 | Re: strange code in array_in |