Skip site navigation (1) Skip section navigation (2)

Re: Nullability patch take 2

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Nullability patch take 2
Date: 2002-04-01 04:41:33
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-patches
Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au> writes:
> Updated to match Tom's new semantics.  passes my own regression tests plus
> all existing ones...

Checked and applied.  I made one nontrivial change --- for anything on
which there's a syscache, it's a lot easier (and faster) to use
SearchSysCacheCopy to get a tuple to update than it is to do a heapscan.
The syscache will either have the tuple already, or will get it with an
indexscan --- either way wins over a heapscan when the catalog is at
all large.

(One of the things on my to-do list is to get rid of unnecessary
heapscans on system tables; there are still a few of 'em in code
paths that are used enough to be worth worrying about.)

			regards, tom lane

In response to


pgsql-patches by date

Next:From: Christopher Kings-LynneDate: 2002-04-01 05:21:22
Subject: Re: Nullability patch take 2
Previous:From: Rod TaylorDate: 2002-03-31 21:38:23
Subject: pg_depend support

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group