| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | pgstattuple: Have pgstattuple_approx accept TOAST tables |
| Date: | 2020-04-17 11:01:46 |
| Message-ID: | 27c4496a-02b9-dc87-8f6f-bddbef54e0fe@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I alluded to this in [0], but it's better discussed in its own thread.
I think the check that makes pgstattuple_approx reject TOAST tables is a
mistake. They have visibility and free space map, and it works just
fine if the check is removed.
Attached is a patch to fix this and add some tests related to how
pgstattuple and pg_visibility accept TOAST tables for inspection.
[0]:
https://www.postgresql.org/message-id/dc35a398-37d0-75ce-07ea-1dd71d98f8ec@2ndquadrant.com
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-pgstattuple-Have-pgstattuple_approx-accept-TOAST-tab.patch | text/plain | 8.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Prabhat Sahu | 2020-04-17 11:26:55 | Re: [Proposal] Global temporary tables |
| Previous Message | Andreas Karlsson | 2020-04-17 09:57:12 | Re: Support for DATETIMEOFFSET |