Re: Converting plpgsql to use DTYPE_REC for named composite types

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Converting plpgsql to use DTYPE_REC for named composite types
Date: 2018-02-13 18:13:02
Message-ID: 27967.1518545582@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
> 2017-12-30 0:16 GMT+01:00 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
>>> I'll stick this into the January commitfest, but I'd like to get it
>>> reviewed and committed pretty soon, because there are follow-on patches
>>> that need to get done in time for v11 --- in particular, we need to close
>>> out the lack of plpgsql support for domains-over-composite.

> all test passed on my comp too.

Is anyone planning on doing further review of this patch than Pavel
already did? If not, I'd like to go ahead and push it, since there's
still followup stuff that I'd like to address for v11. As noted upthread,
there are places where plpgsql fails to enforce DOMAIN NOT NULL
constraints, and I think I had some other squishy things in my notes.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bear Giles 2018-02-13 18:28:49 Re: [GSoC Idea Discussion] "Thrift datatype support" Project
Previous Message Vladimir Sitnikov 2018-02-13 17:24:27 Re: [GSoC Idea Discussion] "Thrift datatype support" Project