| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | d(dot)kovalenko(at)postgrespro(dot)ru |
| Cc: | Álvaro Herrera <alvherre(at)kurilemu(dot)de>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18960: Mistake in test test_simple_pipeline (libpq_pipeline.c) |
| Date: | 2025-06-21 20:01:03 |
| Message-ID: | 2790652.1750536063@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
I wrote:
> I agree that's wrong ... but looking around, there's a huge amount
> of random inconsistency in this test script --- this same simple
> task of checking for an expected NULL result is coded several
> different ways with varying amounts of detail provided, and
> some other places share this same outright bug.
> I think it'd be better to make a helper function
> "CheckNoMoreResults(conn)", or something along that line,
> to shorten and standardize these places.
Here's a shot at improving matters. I also made an effort
at cleaning up memory leaks in libpq_pipeline.c, although
that's surely neatnik-ism not anything meaningful.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| v1-clean-up-libpq-pipeline-tests.patch | text/x-diff | 30.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Kovalenko | 2025-06-21 20:42:42 | Re: BUG #18960: Mistake in test test_simple_pipeline (libpq_pipeline.c) |
| Previous Message | Masahiko Sawada | 2025-06-21 00:17:32 | Re: Logical replication 'invalid memory alloc request size 1585837200' after upgrading to 17.5 |