Philip Warner <pjw(at)rhyme(dot)com(dot)au> writes:
> At 01:58 AM 24/08/2004, Alvaro Herrera wrote:
>> static int _isIdentChar(unsigned char c)
> I think the correct thing to do is to leave it as (signed) char, and remove
> the comparison to \200 = -127.
No, that isn't the right thing, because not all platforms think char is
signed. I prefer declaring it as unsigned, which means you drop the
\377 end instead ...
regards, tom lane
In response to
pgsql-hackers by date
|Next:||From: Philip Warner||Date: 2004-08-24 03:32:07|
|Subject: Re: New warning in pg_dump |
|Previous:||From: Tom Lane||Date: 2004-08-24 03:21:28|
|Subject: Re: auto-casting a bit more intelligent in 8.0 ... ? |