Re: [PATCH] ruleutils: Fix subqueries with shadowed aliases

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Philip Dubé <Philip(dot)Dub(at)microsoft(dot)com>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] ruleutils: Fix subqueries with shadowed aliases
Date: 2019-06-12 23:46:13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

=?iso-8859-1?Q?Philip_Dub=E9?= <Philip(dot)Dub(at)microsoft(dot)com> writes:
> Discovered while looking into issue here:
> For completeness I'll quote the example code to demonstrate the issue:
> ...
> Where the 2nd join_alias should be renamed to join_alias_1

Good catch! The proposed test case is less good though, because
it doesn't actually exercise the bug, ie the test case passes
with or without the code change. (You also stuck it into the
middle of a bunch of not-very-related test cases.) I adapted
your example into a better test case and pushed it. Thanks
for the report and fix.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2019-06-13 00:19:50 Re: Adaptive query optimization
Previous Message David Rowley 2019-06-12 22:36:44 Re: Should we warn against using too many partitions?