| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Raising the SCRAM iteration count |
| Date: | 2023-03-24 08:56:29 |
| Message-ID: | 271710AC-D588-4060-9898-F85C719C4D7D@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 24 Mar 2023, at 00:33, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Thu, Mar 23, 2023 at 10:46:56PM +0100, Daniel Gustafsson wrote:
>> I'm fairly convinced it's a timeout in the interactive psql session. Given how
>> ugly the use of that is I'm sort of waiting for Andres' refactoring patch [0] to
>> commit this such that I can rewrite the test in a saner and more robust way.
>
> FWIW, I'd be OK here even if you don't have a test for libpq in the
> first change as what you have sent is already testing for the core
> machinery in scram-common.c. You could always add one later.
Yeah, that's my fallback in case we are unable to get the TAP refactoring done
in time for the end of the CF/feature freeze.
I've actually ripped out the test in question in the attached v9 to have it
ready and building green in CFbot.
--
Daniel Gustafsson
| Attachment | Content-Type | Size |
|---|---|---|
| v9-0001-Make-SCRAM-iteration-count-configurable.patch | application/octet-stream | 15.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | wangw.fnst@fujitsu.com | 2023-03-24 09:06:45 | RE: Data is copied twice when specifying both child and parent table in publication |
| Previous Message | Daniel Gustafsson | 2023-03-24 08:07:02 | Re: fix a typo in file src/backend/utils/adt/xid8funcs.c comment |