| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Greg Smith <gsmith(at)gregsmith(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, Greg Stark <gsstark(at)mit(dot)edu>, Dimitri Fontaine <dfontaine(at)hi-media(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Parsing config files in a directory |
| Date: | 2009-10-28 16:26:28 |
| Message-ID: | 27157.1256747188@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Greg Smith <gsmith(at)gregsmith(dot)com> writes:
> The sketched out design I have for a contrib/pgtune in C presumes that I'd
> start by refactoring the relevant bits from initdb into a library for both
> programs to use. But the initdb code doesn't care about preserving
> existing values when making changes to them; it just throws in its new
> settings and moves along. So what's there already only handles about half
> the annoying parts most people would expect a tuning tool that reads the
> existing file and operates on it to do.
> Also, I wouldn't be surprised to find that it chokes on some real-world
> postgresql.conf files. The postgresql.conf.sample it's being fed is
> fairly pristine.
Indeed. Why in the world are you looking at initdb? The standard
reference for postgresql.conf-reading code, by definition, is
guc-file.l. I think the odds of building something that works right,
without borrowing that same flex logic, are about nil.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2009-10-28 16:39:34 | Re: Parsing config files in a directory |
| Previous Message | Greg Smith | 2009-10-28 16:10:04 | Re: Parsing config files in a directory |