Re: global / super barriers (for checksums)

From: Sergei Kornilov <sk(at)zsrv(dot)org>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Magnus Hagander <magnus(at)hagander(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: global / super barriers (for checksums)
Date: 2019-12-17 18:44:51
Message-ID: 26977391576608291@myt5-5e0e3f348369.qloud-c.yandex.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello

> Stellar. If nobody objects in the meantime, I plan to commit 0001-0003
> next week.

My compiler (gcc 8.3.0) is not happy with recent 5910d6c7e311f0b14e3d3cb9ce3597c01d3a3cde commit:

autovacuum.c:831:1: error: ‘AutoVacLauncherShutdown’ was used with no prototype before its definition [-Werror=missing-prototypes]
checkpointer.c:524:1: error: ‘HandleCheckpointerInterrupts’ was used with no prototype before its definition [-Werror=missing-prototypes]

I think definition should looks as in attached patch. With this change build is clean

regards, Sergei

Attachment Content-Type Size
gcc_missing_prototypes.patch text/x-diff 1.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2019-12-17 19:00:22 Re: global / super barriers (for checksums)
Previous Message Mahendra Singh 2019-12-17 18:39:10 Re: [HACKERS] Block level parallel vacuum