Skip site navigation (1) Skip section navigation (2)

Re: fix of some issues with multi-line query editing

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: "Sergey E(dot) Koposov" <math(at)sai(dot)msu(dot)ru>, pgsql-patches(at)postgresql(dot)org, alvherre(at)commandprompt(dot)com
Subject: Re: fix of some issues with multi-line query editing
Date: 2006-03-13 04:24:35
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-patches
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>> 3) Fix the handling of commands with not closed brackets, quotes, double 
>> quotes. (now those commands are not splitted in parts...)

Really?  CVS tip seems to treat a multiline command as a single history
entry *unless* it contains newlines within quoted strings (including
single, double, dollar quotes) or newlines within /* comments.

I think this patch is seriously broken, and I don't agree with what it's
trying to accomplish in the first place --- I still haven't found any
cases where it's an improvement to pull back multiple lines as one
history entry.  For example, if you made a mistake on the fifth line of
a ten-line CREATE TABLE command, the current code makes it extremely
inconvenient to fix that: you have to back-arrow or forward-arrow
tediously over five lines, where before you could pull back one line at
a time and just edir the line that needed fixing.

I'm still a vote to revert the patch altogether.  But there is no theory
under which the current behavior is sane.

			regards, tom lane

In response to


pgsql-patches by date

Next:From: Mark KirkwoodDate: 2006-03-13 04:37:00
Subject: Re: [PATCHES] pg_freespacemap question
Previous:From: Christopher Kings-LynneDate: 2006-03-13 03:29:44
Subject: Re: [PATCHES] pg_freespacemap question

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group