Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> writes: > Here is a WIP patch to extensible executor nodes.
I am of the opinion that a run-time-extensible set of plan node types is merest fantasy. We will never have that, so putting in place 5% of the infrastructure for it is a waste of time and notational complexity.
I would support replacing the switch in ExecProcNode with a function-pointer call on performance grounds. The implementation of that IMHO should match what's done for runtime expression state nodes: set up the function pointer in the InitNode function that creates the executor state node. But the rest of this patch, particularly the addition of vtables to plan nodes, is pointless complication.