Re: [PATCHES] Implement support for TCP_KEEPCNT, TCP_KEEPIDLE, TCP_KEEPINTVL (was Re: [HACKERS] Feature freeze date for 8.1)

Oliver Jowett <oliver(at)opencloud(dot)com> writes:
> The assumption I'm making is that if the TCP_* values are present at
> compile time, then you can make a setsockopt() call and get a sane error
> code back if there's no support -- rather than a segfault, or having the
> OS spontaneously do weird things to the connection, or anything like
> that. Is that a reasonable thing to assume?

Well, on a sane OS it's reasonable. I dunno about Windows ;-)

One question to ask is whether we should treat the setsockopt failure
as fatal or not. It seems to me that aborting the connection could
reasonably be called an overreaction to a bad parameter setting;
couldn't we just set the GUC variable to zero and keep going?

regards, tom lane