Skip site navigation (1) Skip section navigation (2)

Re: COPY FROM performance improvements

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Luke Lonergan" <LLonergan(at)greenplum(dot)com>
Cc: "Simon Riggs" <simon(at)2ndquadrant(dot)com>,"Alon Goldshuv" <agoldshuv(at)greenplum(dot)com>,pgsql-patches(at)postgresql(dot)org
Subject: Re: COPY FROM performance improvements
Date: 2005-08-10 15:37:57
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-patches
"Luke Lonergan" <LLonergan(at)greenplum(dot)com> writes:
> Yes, I think one thing we've learned is that there are important parts
> of the code, those that are in the data path (COPY, sort, spill to
> disk, etc) that are in dire need of optimization.  For instance, the
> fgetc() pattern should be banned everywhere in the data path.

Luke, I dislike whacking people upside the head, but this discussion
seems to presume that raw speed on Intel platforms is the only thing
that matters.  We have a few other concerns.  Portability, readability,
maintainability, and correctness all trump platform-specific
optimizations.  The COPY patch as presented lost badly on all those
counts, and you are lucky that it didn't get rejected completely.

			regards, tom lane

In response to


pgsql-patches by date

Next:From: Martijn van OosterhoutDate: 2005-08-10 15:39:24
Subject: Re: 5 new entries for FAQ
Previous:From: Tom LaneDate: 2005-08-10 15:29:49
Subject: Re: COPY FROM performance improvements

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group